Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UTOPIA-1558] Implement package for text editor on Storing personal information tab #1787

Merged
merged 3 commits into from
Nov 16, 2023
Merged

[UTOPIA-1558] Implement package for text editor on Storing personal information tab #1787

merged 3 commits into from
Nov 16, 2023

Conversation

JieunSon96
Copy link
Contributor

@JieunSon96 JieunSon96 commented Nov 16, 2023 •
edited
Loading

🎯 Summary

UTOPIA-1558

  • Updated jsonb types in the backend and updated mocks.
  • Created migration.
  • Replaced text editor on storing PI tab.
  • Ensured tests pass in the backend.
  • Removed code related to md-editior on collection, use, disclosure tab.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • I have consulted with the team if introducing a new dependency.
  • My changes generate no new warnings.

@JieunSon96 JieunSon96 self-assigned this Nov 16, 2023
@github-actions github-actions bot added DPIA API PR contains changes to DPIA API DPIA Web App PR contains changes to DPIA frontend app labels Nov 16, 2023
BradyMitch
BradyMitch approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@BradyMitch BradyMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@JieunSon96 JieunSon96 merged commit 04c41da into main Nov 16, 2023
14 of 15 checks passed
@JieunSon96 JieunSon96 deleted the UTOPIA-1558-bd branch November 16, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradyMitch BradyMitch BradyMitch approved these changes

@antsand antsand Awaiting requested review from antsand antsand is a code owner

@Bottle7 Bottle7 Awaiting requested review from Bottle7 Bottle7 is a code owner

@akroon3r akroon3r Awaiting requested review from akroon3r akroon3r is a code owner

@NoorChasib NoorChasib Awaiting requested review from NoorChasib NoorChasib is a code owner

Assignees

@JieunSon96 JieunSon96

Labels
DPIA API PR contains changes to DPIA API DPIA Web App PR contains changes to DPIA frontend app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JieunSon96 @BradyMitch